[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/10] vTPM for aarch64

From: Stefan Berger
Subject: Re: [PATCH v3 00/10] vTPM for aarch64
Date: Wed, 26 Feb 2020 15:01:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1

On 2/26/20 1:18 PM, Auger Eric wrote:
Hi Stefan,

On 2/26/20 6:53 PM, Stefan Berger wrote:
On 2/26/20 12:47 PM, Auger Eric wrote:
Hi Stefan,

On 2/26/20 2:32 PM, Stefan Berger wrote:
On 2/26/20 5:25 AM, Eric Auger wrote:
This series adds the capability to instantiate an MMIO TPM TIS
in ARM virt. It is candidate to qemu 5.0.
Looks good. Can you run the checkpatch script over the patches and
address the warnings?

Thank you for you review!

About warnings

- There are warnings due to new files added but I think they all have an
entry in MAINTAINERS as wildcards are used.

- In tpm: Add the SysBus TPM TIS device.
    There is line over 80 chars but I think it is fine

#define TPM_TIS_SYSBUS(obj) OBJECT_CHECK(TPMStateSysBus, (obj),

Ok, leave it as it is.
and sorry, what about the comment style issues derived from existing files?

- test: tpm-tis: Get prepared to share tests between ISA and sysbus devices
has lots of warnings due to old comment style being used in
tests/qtest/tpm-tis-test.c. I did not fix the style issue because I just
copy the code into tpm-tis-util.c

Do you want me to fix them in the same patch, in a separate patch or
ignore the style issue for now?

if you could fix them that would be great...





reply via email to

[Prev in Thread] Current Thread [Next in Thread]