[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v4 10/13] arm/arm64: ITS: INT functional tests
From: |
Andrew Jones |
Subject: |
Re: [kvm-unit-tests PATCH v4 10/13] arm/arm64: ITS: INT functional tests |
Date: |
Mon, 9 Mar 2020 12:43:58 +0100 |
On Mon, Mar 09, 2020 at 11:24:17AM +0100, Eric Auger wrote:
...
> diff --git a/lib/arm/asm/gic-v3-its.h b/lib/arm/asm/gic-v3-its.h
> index 0096de6..956d7b8 100644
> --- a/lib/arm/asm/gic-v3-its.h
> +++ b/lib/arm/asm/gic-v3-its.h
> @@ -5,9 +5,8 @@
> *
> * This work is licensed under the terms of the GNU LGPL, version 2.
> */
> -
> -#ifndef _ASMARM_GICv3_ITS
> -#define _ASMARM_GICv3_ITS
> +#ifndef _ASMARM_GIC_V3_ITS_H_
> +#define _ASMARM_GIC_V3_ITS_H_
Another fix to squash into the patch where the lines are introduced.
>
> /* dummy its_data struct to allow gic_get_dt_bases() call */
> struct its_data {
> @@ -19,5 +18,9 @@ static inline void test_its_introspection(void)
> {
> report_abort("not supported on 32-bit");
> }
> +static inline void test_its_trigger(void)
> +{
> + report_abort("not supported on 32-bit");
As mentioned before, we don't want test_* and report_* functions in the
library code.
> +}
>
> #endif /* _ASMARM_GICv3_ITS */
Forgot to change _ASMARM_GICv3_ITS here.
> --
> 2.20.1
>
Thanks,
drew
- Re: [kvm-unit-tests PATCH v4 06/13] arm/arm64: ITS: Introspection tests, (continued)
- [kvm-unit-tests PATCH v4 08/13] arm/arm64: ITS: Device and collection Initialization, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 09/13] arm/arm64: ITS: Commands, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 10/13] arm/arm64: ITS: INT functional tests, Eric Auger, 2020/03/09
- Re: [kvm-unit-tests PATCH v4 10/13] arm/arm64: ITS: INT functional tests,
Andrew Jones <=
- [kvm-unit-tests PATCH v4 11/13] arm/run: Allow Migration tests, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 12/13] arm/arm64: ITS: migration tests, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 13/13] arm/arm64: ITS: pending table migration test, Eric Auger, 2020/03/09
- Re: [kvm-unit-tests PATCH v4 00/13] arm/arm64: Add ITS tests, Andrew Jones, 2020/03/09