Re: [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests

[Auger Eric]

Hi Zenghui,

On 3/11/20 9:37 AM, Zenghui Yu wrote:
> Hi Eric,
> 
> On 2020/3/10 22:54, Eric Auger wrote:
>> +#define GITS_TYPER_PLPIS                BIT(0)
>> +#define GITS_TYPER_VLPIS        BIT(1)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE    GENMASK_ULL(7, 4)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE_SHIFT    4
>> +#define GITS_TYPER_IDBITS        GENMASK_ULL(8, 12)
> 
> Note that this should be GENMASK_ULL(12, 8).
definitively

Eric
> 
>> +#define GITS_TYPER_IDBITS_SHIFT         8
>> +#define GITS_TYPER_DEVBITS        GENMASK_ULL(13, 17)
> 
> (17, 13)
> 
>> +#define GITS_TYPER_DEVBITS_SHIFT        13
>> +#define GITS_TYPER_PTA                  BIT(19)
>> +#define GITS_TYPER_CIDBITS        GENMASK_ULL(32, 35)
> 
> (35, 32)
> 
>> +#define GITS_TYPER_CIDBITS_SHIFT    32
>> +#define GITS_TYPER_CIL            BIT(36)
> 
> And please use tab for all of them.
> 
> 
> Thanks,
> Zenghui
>