[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked
From: |
Peter Maydell |
Subject: |
Re: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked |
Date: |
Thu, 12 Mar 2020 12:01:57 +0000 |
On Tue, 3 Mar 2020 at 09:13, Igor Mammedov <address@hidden> wrote:
>
> SOC object returned by object_new() is leaked in current code.
> Set SOC parent explicitly to board and then unref to SOC object
> to make sure that refererence returned by object_new() is taken
> care of.
>
> The SOC object will be kept alive by its parent (machine) and
> will be automatically freed when MachineState is destroyed.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reported-by: Andrew Jones <address@hidden>
> ---
> hw/arm/cubieboard.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Applied to target-arm.next, thanks.
-- PMM