[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes
From: |
Laurent Vivier |
Subject: |
Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes |
Date: |
Mon, 23 Mar 2020 15:32:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
> Fix trivial warnings reported by the Clang static code analyzer.
>
> Since v1:
> - Addressed Markus/Zoltan/Aleksandar review comments
>
> Philippe Mathieu-Daudé (11):
> block: Avoid dead assignment
> blockdev: Remove dead assignment
> hw/i2c/pm_smbus: Remove dead assignment
> hw/input/adb-kbd: Remove dead assignment
> hw/ide/sii3112: Remove dead assignment
> hw/isa/i82378: Remove dead assignment
> hw/gpio/aspeed_gpio: Remove dead assignment
> hw/timer/exynos4210_mct: Remove dead assignments
> hw/timer/stm32f2xx_timer: Remove dead assignment
> hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning
> hw/scsi/esp-pci: Remove dead assignment
>
> block.c | 2 +-
> blockdev.c | 2 +-
> hw/gpio/aspeed_gpio.c | 2 +-
> hw/i2c/pm_smbus.c | 1 -
> hw/ide/sii3112.c | 5 +++--
> hw/input/adb-kbd.c | 6 +-----
> hw/isa/i82378.c | 8 ++++----
> hw/scsi/esp-pci.c | 1 -
> hw/timer/exynos4210_mct.c | 3 ---
> hw/timer/pxa2xx_timer.c | 1 +
> hw/timer/stm32f2xx_timer.c | 1 -
> 11 files changed, 12 insertions(+), 20 deletions(-)
>
I think your series covers cases already covered by:
[PATCH v3 00/12] redundant code: Fix warnings reported by Clang static
code analyzer
https://patchew.org/QEMU/20200302130715.29440-1-kuhn.ch
Thanks,
Laurent
- Re: [PATCH-for-5.0 v2 07/11] hw/gpio/aspeed_gpio: Remove dead assignment, (continued)
- [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 11/11] hw/scsi/esp-pci: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes,
Laurent Vivier <=