[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0] target/arm: PSTATE.PAN should not clear exec bits
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH for-5.0] target/arm: PSTATE.PAN should not clear exec bits |
|
Date: |
Mon, 30 Mar 2020 12:41:54 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/30/20 10:06 AM, Peter Maydell wrote:
> Our implementation of the PSTATE.PAN bit incorrectly cleared all
> access permission bits for privileged access to memory which is
> user-accessible. It should only affect the privileged read and write
> permissions; execute permission is dealt with via XN/PXN instead.
>
> Fixes: 81636b70c226dc27d7ebc8d
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Compare the pseudocode AArch64.CheckPermission().
> ---
> target/arm/helper.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Oops,
Reviewed-by: Richard Henderson <address@hidden>
r~