[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code |
|
Date: |
Tue, 31 Mar 2020 15:23:23 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> This series is inspired of Peter fix:
> "hw/arm/xlnx-zynqmp.c: fix some error-handling code"
> https://www.mail-archive.com/address@hidden/msg691636.html
>
> Add a cocci script to fix the other places.
>
> Based-on: <address@hidden>
I skimmed the code patches [PATCH 02-12/12], and they look like bug
fixes. Other reviewers raised a few issues.
I also skimmed the Coccinelle script [PATCH 01]. Peter pointed out a
few things it apparently missed (e.g. in review of PATCH 06+11).
Moreover, the bug pattern applies beyond object_property_set() &
friends. Perhaps the script can be generalized. No reason to hold
fixes. We may want to add suitable notes to the scipt, though.
Can you address the reviews in a v2, so we can get the fixes into -rc1,
due today?