[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Remove obsolete TODO note from get_phys_addr_lpa
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] target/arm: Remove obsolete TODO note from get_phys_addr_lpae() |
|
Date: |
Tue, 31 Mar 2020 09:06:18 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/31/20 7:34 AM, Peter Maydell wrote:
> An old comment in get_phys_addr_lpae() claims that the code does not
> support the different format TCR for VTCR_EL2. This used to be true
> but it is not true now (in particular the aa64_va_parameters() and
> aa32_va_parameters() functions correctly handle the different
> register format by checking whether the mmu_idx is Stage2).
> Remove the out of date parts of the comment.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Randomly noticed this out of date comment while I was stepping
> through the code this afternoon...
>
> target/arm/helper.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~