[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG acc

From: Peter Maydell
Subject: Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel
Date: Fri, 17 Apr 2020 15:24:25 +0100

On Fri, 17 Apr 2020 at 15:19, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 4/17/20 3:54 PM, Peter Maydell wrote:
> > Your suggested patch isn't quite the same as RTH's suggestion,
> > because it puts the assert inside a stub probe_read()
> > implementation rather than having the ifdef at the level
> > of the writefn body. I have no opinion on whether one or
> > the other of these is preferable.
> I'll let Richard modify the writefn() bodies if required, as he
> understand what they do :)

RTH is suggesting

static void dccvap_writefn(CPUARMState *env, const ARMCPRegInfo *opaque,
                          uint64_t value)
    entire current body of function goes here

If we take that approach then the stub probe_read() would
be pointless, so we should do one or the other, not both.

> Btw since we have this rule:
> obj-$(call lnot,$(CONFIG_TCG))  += tcg-stub.o
> I'll use the following patch which is less intrusive:

This is temptingly less ifdeffery, certainly

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]