[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/5] target/arm: Restrict TCG cpus to TCG accel

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 0/5] target/arm: Restrict TCG cpus to TCG accel
Date: Mon, 27 Apr 2020 15:42:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/27/20 3:04 PM, Peter Maydell wrote:
On Thu, 23 Apr 2020 at 08:34, Philippe Mathieu-Daudé <address@hidden> wrote:

These are the uncontroversial patches from "Support disabling
TCG on ARM (part 2)"

The other patches are blocked by the "accel: Allow targets to
use Kconfig" series:

All patches reviewed.

Since v1:
- Dropped 'Make set_feature() available for other files' patch
   which fails to build with KVM only, see:

Many thanks to Richard Henderson for his patience!



Philippe Mathieu-Daudé (4):
   target/arm: Restric the Address Translate write operation to TCG accel
   target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]
   target/arm/cpu: Update coding style to make checkpatch.pl happy
   target/arm: Restrict TCG cpus to TCG accel

Thomas Huth (1):
   target/arm: Make cpu_register() available for other files

Patch 5 doesn't compile, because it moves code out from
cpu.c to cpu_tcg.c, where it no longer has access to the
file-local set_feature() function:

   CC      arm-softmmu/target/arm/cpu_tcg.o
error: implicit declaration of function 'set_feature' is invalid in
     set_feature(&cpu->env, ARM_FEATURE_V5);

*Sigh* sorry for that, I'm still unsure what's the cleaner change to deal with the different set_feature() KVM prototype:

I've applied patches 1-4 to target-arm.next.

Thanks for this!

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]