[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tpm: tpm-tis-device: set PPI to false by default

From: Stefan Berger
Subject: Re: [PATCH 1/2] tpm: tpm-tis-device: set PPI to false by default
Date: Tue, 28 Apr 2020 16:13:50 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 4/28/20 6:34 AM, Cornelia Huck wrote:
On Mon, 27 Apr 2020 16:31:44 +0200
Eric Auger <address@hidden> wrote:

The tpm-tis-device device does not support PPI. Let's
change the default value for the corresponding property
instead of tricking this latter in the mach-virt machine.

Signed-off-by: Eric Auger <address@hidden>
  hw/tpm/tpm_tis_sysbus.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
index 18c02aed67..eced1fc843 100644
--- a/hw/tpm/tpm_tis_sysbus.c
+++ b/hw/tpm/tpm_tis_sysbus.c
@@ -91,7 +91,7 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
  static Property tpm_tis_sysbus_properties[] = {
      DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
      DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
-    DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, true),
+    DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false),
This looks like a better place to do this than in the virt compat
machines, and should get us the same result, leaving compatibility

Reviewed-by: Cornelia Huck <address@hidden>

Reviewed-by: Stefan Berger <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]