[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated d
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic |
|
Date: |
Fri, 8 May 2020 08:33:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/05/20 08:24, Philippe Mathieu-Daudé wrote:
> It is not clear if dccvap_writefn() really needs
> memory_region_writeback() or could use memory_region_msync().
Indeed, I don't understand the code and why it matters that
mr->dirty_log_mask is nonzero.
mr->dirty_log_mask tells if dirty tracking has been enabled, not if the
page is dirty. It would always be true during live migration and when
running on TCG, but otherwise it would always be false.
Beata, can you explain what you had in mind? :)
Paolo
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Stefan Hajnoczi, 2020/05/21
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Stefan Hajnoczi, 2020/05/27