[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices |
Date: |
Mon, 25 May 2020 14:32:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 25/05/20 07:50, Markus Armbruster wrote:
> Peter Maydell <address@hidden> writes:
>
>> On Mon, 18 May 2020 at 06:04, Markus Armbruster <address@hidden> wrote:
>>> These devices are optional, and enabled by property "enable-bitband".
>>> armv7m_instance_init() creates them unconditionally, because the
>>> property has not been set then. armv7m_realize() realizes them only
>>> when the property is true. Works, although it leaves unrealized
>>> devices hanging around in the QOM composition tree. Affects machines
>>> microbit, mps2-an505, mps2-an521, musca-a, and musca-b1.
>>>
>>> Bury the unwanted devices by making armv7m_realize() unparent them.
>>> Visible in "info qom-tree"; here's the change for microbit:
>>
>> What does "bury" mean here? To me it implies "they still
>> exist but we've stuck them in a hole somewhere and covered
>> them up", but the qom-tree delta suggests we've actually
>> really deleted them?
>
> We really delete them now.
>
> "They've been lying dead in the streets; give them a decent burial".
>
> Would you like me to s/Bury/Delete/?
"Bury unwanted" -> "Dispose of unused"?
Paolo