qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/7] target/arm: Convert Neon 3-reg-diff narrowing ops to dec


From: Richard Henderson
Subject: Re: [PATCH 3/7] target/arm: Convert Neon 3-reg-diff narrowing ops to decodetree
Date: Tue, 9 Jun 2020 10:40:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/9/20 9:02 AM, Peter Maydell wrote:
> +#define DO_NARROW_3D(INSN, OP, NARROWTYPE, EXTOP)                       \
> +    static bool trans_##INSN##_3d(DisasContext *s, arg_3diff *a)        \
> +    {                                                                   \
> +        NeonGenTwo64OpFn *addfn[] = {                                   \
> +            gen_helper_neon_##OP##l_u16,                                \
> +            gen_helper_neon_##OP##l_u32,                                \
> +            tcg_gen_##OP##_i64,                                         \
> +            NULL,                                                       \
> +        };                                                              \
> +        NeonGenNarrowFn *narrowfn[] = {                                 \
> +            gen_helper_neon_##NARROWTYPE##_high_u8,                     \
> +            gen_helper_neon_##NARROWTYPE##_high_u16,                    \
> +            EXTOP,                                                      \
> +            NULL,                                                       \
> +        };                                                              \
> +        return do_narrow_3d(s, a, addfn[a->size], narrowfn[a->size]);   \
> +    }

Missing const again.  Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]