|
From: | Richard Henderson |
Subject: | Re: [PATCH v7 30/42] target/arm: Use mte_check1 for sve LD1R |
Date: | Fri, 19 Jun 2020 12:40:17 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/19/20 7:03 AM, Peter Maydell wrote: >> static bool trans_LD1R_zpri(DisasContext *s, arg_rpri_load *a) >> { >> - if (!sve_access_check(s)) { >> - return true; >> - } >> - >> unsigned vsz = vec_full_reg_size(s); >> unsigned psz = pred_full_reg_size(s); >> unsigned esz = dtype_esz[a->dtype]; >> unsigned msz = dtype_msz(a->dtype); >> TCGLabel *over = gen_new_label(); >> - TCGv_i64 temp; >> + TCGv_i64 temp, clean_addr; >> + >> + if (!sve_access_check(s)) { >> + return true; >> + } > > This cleanup should really be its own patch. > > We should probably not call gen_new_label() until after > the sve_access_check() ? Done. r~
[Prev in Thread] | Current Thread | [Next in Thread] |