[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system m
From: |
Richard Henderson |
Subject: |
Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode |
Date: |
Thu, 25 Jun 2020 10:02:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/25/20 6:03 AM, Peter Maydell wrote:
> On Tue, 23 Jun 2020 at 20:38, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Look up the physical address for the given virtual address,
>> convert that to a tag physical address, and finally return
>> the host address that backs it.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> target/arm/mte_helper.c | 126 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 126 insertions(+)
>>
>
>> + /* If not normal memory, there is no tag storage: access unchecked. */
>> + if (unlikely(flags & TLB_MMIO)) {
>
> Comment says we're checking a memory attribute, but the code
> is checking for TLB_MMIO, which isn't the same thing.
Comment is not trying to allude to Normal vs Device, but "ram" vs "mmio" in the
qemu sense.
r~
- [PATCH v8 39/45] target/arm: Implement data cache set allocation tags, (continued)
- [PATCH v8 39/45] target/arm: Implement data cache set allocation tags, Richard Henderson, 2020/06/23
- [PATCH v8 40/45] target/arm: Set PSTATE.TCO on exception entry, Richard Henderson, 2020/06/23
- [PATCH v8 41/45] target/arm: Always pass cacheattr to get_phys_addr, Richard Henderson, 2020/06/23
- [PATCH v8 42/45] target/arm: Cache the Tagged bit for a page in MemTxAttrs, Richard Henderson, 2020/06/23
- [PATCH v8 43/45] target/arm: Create tagged ram when MTE is enabled, Richard Henderson, 2020/06/23
- [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode, Richard Henderson, 2020/06/23
[PATCH v8 45/45] target/arm: Enable MTE, Richard Henderson, 2020/06/23
Re: [PATCH v8 00/45] target/arm: Implement ARMv8.5-MemTag, system mode, Derrick McKee, 2020/06/23
Re: [PATCH v8 00/45] target/arm: Implement ARMv8.5-MemTag, system mode, no-reply, 2020/06/23
Re: [PATCH v8 00/45] target/arm: Implement ARMv8.5-MemTag, system mode, Peter Maydell, 2020/06/25