Re: [PATCH v3 00/12] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

[Philippe Mathieu-Daudé]

On 7/3/20 11:15 PM, Havard Skinnemoen wrote:
> On Fri, Jul 3, 2020 at 6:35 AM Philippe Mathieu-Daudé <philmd@redhat.com> 
> wrote:
>>
>> On 7/3/20 2:27 PM, Peter Maydell wrote:
>>> On Sat, 27 Jun 2020 at 00:55, Havard Skinnemoen <hskinnemoen@google.com> 
>>> wrote:
>>>>
>>>> Time for another refresh of this patchset. Sorry it took so long -- I've 
>>>> been
>>>> trying to figure out why the Winbond flash model isn't working with
>>>> npcm750-evb, and I'm fairly convinced the number of dummy cycles in DIO 
>>>> mode
>>>> should be 4, not 1. Unfortunately, I don't see any other machines using 
>>>> Winbond
>>>> flash in DIO mode, so it's hard to prove that it's correct. I'm planning to
>>>> post a libqos-based test suite separately.
>>>>
>>>> I'm also planning to add the vbootrom to qemu as a submodule, similar to 
>>>> the
>>>> other roms, but not in this pathset (let me know if you do want me to 
>>>> include
>>>> this in the series).
>>>
>>> Hi; it looks like codewise this patchset is ready to go in
>>> and it's all been reviewed. I see however that all the
>>> new files are GPL-v2-only. We usually prefer GPL-v2-or-later
>>> for new code: is it possible to use that license instead ?
>>
>> This series has been posted before Markus qdev & error cleanups.
>> Maybe some newer error patterns should be used now instead?
> 
> I'm not sure if I understand exactly what you're referring to, but
> I'll do 'git log origin/master --author=armbru@redhat.com' to see if I
> can apply any similar fixes or cleanups to this series.

Sorry this was a quick comment for Peter, that he might get conflicts
when applying.

See Markus "Fix realize error API violations" commits:
7cd1c981eb, b40181942e & 3e9a88c372, and commit 123327d14
"Clean up roundabout error propagation".