Re: [RFC PATCH 1/2] hw/sd/ssi-sd: Deprecate the SPI to SD card 'adapter'

[Eric Blake]

On 7/5/20 5:07 PM, Philippe Mathieu-Daudé wrote:
> This device duplicate the SPI mode of the sd-card device. The

duplicates

> SPI protocol is better handler in the sd-card, however as the
> TYPE_SSI_SLAVE is not an interface, the sd-card can not implement
> it easily to be pluggable on a SPI bus. Meanwhile the ssi-sd
> device acts as a bridge, but is bitroting. Deprecate it.

bitrotting

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   docs/system/deprecated.rst | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 47f84be8e0..5e67d7f3e0 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -343,6 +343,11 @@ The 'ide-drive' device is deprecated. Users should use 
> 'ide-hd' or
>   The 'scsi-disk' device is deprecated. Users should use 'scsi-hd' or
>   'scsi-cd' as appropriate to get a SCSI hard disk or CD-ROM as needed.
>   
> +``ssi-sd`` (since 5.1)
> +'''''''''''''''''''''''''

Inconsistent line lengths

> +
> +The 'ssi-sd' (SSI to SD card adapter) device is deprecated.

What is the recommended replacement?  Or at least document if it is 
disappearing with no replacement.

> +
>   System emulator machines
>   ------------------------
>   

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org