[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 18/20] tests/acpi: allow override blkdev
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v5 18/20] tests/acpi: allow override blkdev |
Date: |
Fri, 10 Jul 2020 21:48:12 +0200 |
On Tue, 7 Jul 2020 14:53:54 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> microvm needs virtio-blk instead of ide.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858f4..24b715dce780 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -72,6 +72,7 @@ typedef struct {
> const char *variant;
> const char *uefi_fl1;
> const char *uefi_fl2;
> + const char *blkdev;
> const char *cd;
> const uint64_t ram_start;
> const uint64_t scan_len;
> @@ -635,9 +636,10 @@ static void test_acpi_one(const char *params, test_data
> *data)
> args = g_strdup_printf("-machine %s,kernel-irqchip=off %s -accel tcg
> "
> "-net none -display none %s "
> "-drive id=hd0,if=none,file=%s,format=raw "
> - "-device ide-hd,drive=hd0 ",
> + "-device %s,drive=hd0 ",
> data->machine, data->tcg_only ? "" : "-accel kvm",
> - params ? params : "", disk);
> + params ? params : "", disk,
> + data->blkdev ?: "ide-hd");
> }
>
> data->qts = qtest_init(args);
- Re: [PATCH v5 19/20] tests/acpi: add microvm test, (continued)
[PATCH v5 13/20] x86: constify x86_machine_is_*_enabled, Gerd Hoffmann, 2020/07/07
[PATCH v5 12/20] microvm/acpi: disable virtio-mmio cmdline hack, Gerd Hoffmann, 2020/07/07
[PATCH v5 16/20] microvm: wire up hotplug, Gerd Hoffmann, 2020/07/07
[PATCH v5 10/20] microvm/acpi: use GSI 16-23 for virtio, Gerd Hoffmann, 2020/07/07
[PATCH v5 09/20] microvm/acpi: add acpi_dsdt_add_virtio() for x86, Gerd Hoffmann, 2020/07/07
[PATCH v5 18/20] tests/acpi: allow override blkdev, Gerd Hoffmann, 2020/07/07
- Re: [PATCH v5 18/20] tests/acpi: allow override blkdev,
Igor Mammedov <=
[PATCH v5 11/20] microvm/acpi: use seabios with acpi=on, Gerd Hoffmann, 2020/07/07
[PATCH v5 15/20] x86: move cpu plug from pc to x86, Gerd Hoffmann, 2020/07/07
Re: [PATCH v5 00/20] microvm: add acpi support, no-reply, 2020/07/07
Re: [PATCH v5 00/20] microvm: add acpi support, no-reply, 2020/07/07