[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/17] tcg: Introduce target-specific page data for user-o
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 01/17] tcg: Introduce target-specific page data for user-only |
|
Date: |
Sun, 12 Jul 2020 18:44:43 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 6/25/20 9:20 AM, Peter Maydell wrote:
> On Fri, 5 Jun 2020 at 05:17, Richard Henderson
>> @@ -787,9 +788,11 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong
>> old_size,
>> new_addr = -1;
>> } else {
>> new_addr = h2g(host_addr);
>> + /* FIXME: Move page flags and target_data for each page. */
>
> Is this something we're going to address later in the patchset?
I've removed the comment.
The mremap system call is not as general as I think it should be. It only
applies to MAP_SHARED vmas and returns EINVAL on MAP_PRIVATE. Therefore, at
least for the MTE usage of target_data, there cannot be any.
r~