[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/arm: Clarify HCR_EL2 ARMCPRegInfo type

From: Peter Maydell
Subject: Re: [PATCH] target/arm: Clarify HCR_EL2 ARMCPRegInfo type
Date: Mon, 24 Aug 2020 16:21:00 +0100

On Wed, 12 Aug 2020 at 12:12, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> In commit ce4afed839 ("target/arm: Implement AArch32 HCR and HCR2")
> the HCR_EL2 register has been changed from type NO_RAW (no underlying
> state and does not support raw access for state saving/loading) to
> type CONST (TCG can assume the value to be constant), removing the
> read/write accessors.
> We forgot to remove the previous type ARM_CP_NO_RAW. This is not
> really a problem since the field is overwritten. However it makes
> code review confuse, so remove it.
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/arm/helper.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to target-arm.next, thanks.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]