Re: [PATCH v2 02/21] m25p80: Add support for mx25l25635f

[Cédric Le Goater]

On 8/19/20 12:09 PM, Cédric Le Goater wrote:
> The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI
> support, 4-Byte Address Command Set and faster transfers. See this
> document for more details :
> 
> https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_MX25L25635E_25735E%20to%20MX25L25635F_25735F.pdf
> 
> Both devices have the same 3bytes JEDEC ID: 0xc22019. They can be
> distinguished with the QPIID command which is only available on
> mx25l25635f and their Serial Flash Discoverable Parameters. However,
> some FW use the JEDEC ID. For instance, on a SuperMicro P9 Boston, the
> BMC FW reports :
> 
>   BMC flash ID: 0xc21920c2
>   jedec_id: 0xc21920c2
>   flash type: MX25L25635F
>   ReadClk=0x32, WriteClk=0x85, EraseClk=0x85
>   [smcfw_spi] cpuclk: 198000000 MHz, RefCLK: 24000000 MHz, AXI-AHB ratio: 2:1
>   platform_flash: MX25L25635F (32768 Kbytes)
> 
> Define the mx25l25635f with an extended JEDEC ID.

I am starting to think this is a broken driver or a very exotic HW. 
We have a couple of mx25l25635f on other openpower systems and the 
returned JEDEC ID is 0xc21920c21920.

I will keep this patch on the side for now.

Thanks,

C. 

> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  hw/block/m25p80.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 605ff55c6756..1696ab1f7821 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -218,6 +218,7 @@ static const FlashPartInfo known_devices[] = {
>      { INFO("mx25l12805d", 0xc22018,      0,  64 << 10, 256, 0) },
>      { INFO("mx25l12855e", 0xc22618,      0,  64 << 10, 256, 0) },
>      { INFO6("mx25l25635e", 0xc22019,     0xc22019,  64 << 10, 512, 0) },
> +    { INFO("mx25l25635f", 0xc22019,      0xc200,  64 << 10, 512, 0) },
>      { INFO("mx25l25655e", 0xc22619,      0,  64 << 10, 512, 0) },
>      { INFO("mx66u51235f", 0xc2253a,      0,  64 << 10, 1024, ER_4K | ER_32K) 
> },
>      { INFO("mx66u1g45g",  0xc2253b,      0,  64 << 10, 2048, ER_4K | ER_32K) 
> },
>