Re: [PATCH 2/3] hw/arm/bcm2835: Add more unimplemented peripherals

[Luc Michel]

On 9/21/20 5:47 AM, Philippe Mathieu-Daudé wrote:
> The bcm2835-v3d is used since Linux 4.7, see commit
> 49ac67e0c39c ("ARM: bcm2835: Add VC4 to the device tree"),
> and the bcm2835-txp since Linux 4.19, see commit
> b7dd29b401f5 ("ARM: dts: bcm283x: Add Transposer block").
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Luc Michel <luc.michel@greensocs.com>

> ---
>   include/hw/arm/bcm2835_peripherals.h | 2 ++
>   hw/arm/bcm2835_peripherals.c         | 2 ++
>   2 files changed, 4 insertions(+)
>
> diff --git a/include/hw/arm/bcm2835_peripherals.h 
> b/include/hw/arm/bcm2835_peripherals.h
> index b4d3ae121ac..ccd9eb11102 100644
> --- a/include/hw/arm/bcm2835_peripherals.h
> +++ b/include/hw/arm/bcm2835_peripherals.h
> @@ -47,6 +47,7 @@ struct BCM2835PeripheralState {
>   
>       BCM2835SystemTimerState systmr;
>       BCM2835MphiState mphi;
> +    UnimplementedDeviceState txp;
>       UnimplementedDeviceState armtmr;
>       UnimplementedDeviceState cprman;
>       UnimplementedDeviceState a2w;
> @@ -68,6 +69,7 @@ struct BCM2835PeripheralState {
>       UnimplementedDeviceState otp;
>       UnimplementedDeviceState dbus;
>       UnimplementedDeviceState ave0;
> +    UnimplementedDeviceState v3d;
>       UnimplementedDeviceState bscsl;
>       UnimplementedDeviceState smi;
>       DWC2State dwc2;
> diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
> index a9d7f53f6e9..15c5c72e465 100644
> --- a/hw/arm/bcm2835_peripherals.c
> +++ b/hw/arm/bcm2835_peripherals.c
> @@ -343,6 +343,7 @@ static void bcm2835_peripherals_realize(DeviceState *dev, 
> Error **errp)
>           qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ,
>                                  INTERRUPT_USB));
>   
> +    create_unimp(s, &s->txp, "bcm2835-txp", TXP_OFFSET, 0x1000);
>       create_unimp(s, &s->armtmr, "bcm2835-sp804", ARMCTRL_TIMER0_1_OFFSET, 
> 0x40);
>       create_unimp(s, &s->cprman, "bcm2835-cprman", CPRMAN_OFFSET, 0x1000);
>       create_unimp(s, &s->a2w, "bcm2835-a2w", A2W_OFFSET, 0x1000);
> @@ -356,6 +357,7 @@ static void bcm2835_peripherals_realize(DeviceState *dev, 
> Error **errp)
>       create_unimp(s, &s->otp, "bcm2835-otp", OTP_OFFSET, 0x80);
>       create_unimp(s, &s->dbus, "bcm2835-dbus", DBUS_OFFSET, 0x8000);
>       create_unimp(s, &s->ave0, "bcm2835-ave0", AVE0_OFFSET, 0x8000);
> +    create_unimp(s, &s->v3d, "bcm2835-v3d", V3D_OFFSET, 0x1000);
>       create_unimp(s, &s->sdramc, "bcm2835-sdramc", SDRAMC_OFFSET, 0x100);
>   }
>