Re: [PATCH] hw: wdt: implement sbsa watchdog

[Peter Maydell]

On Fri, 2 Oct 2020 at 15:06, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
>
> On Thu, 1 Oct 2020 at 23:36, Peter Maydell <peter.maydell@linaro.org> wrote:
> > Hi; what's the relationship between this SBSA watchdog
> > device model and the one that Shashi posted recently?
> > https://patchew.org/QEMU/20200929180410.33058-1-shashi.mallela@linaro.org/

> Nice it's the same driver written a little bit differently. I did not
> see his patch before. 2 things missing in Sashis driver which are
> useful for me:
> 1. Add sbsa watchdog to machine virt also. That helped me to reboot a
> virtual machine with secure payload.
> 2. I specially did not disable timer on driver close. I.e. "reboot"
> linux path reboots with that watchdog.  And make timeout lower to not
> wait for a long period.

You should get together and figure out a single version of
the patchset that you want to upstream...

> Can this driver also be considered for virt machine?

Maybe, but you'd need to explain why it's useful (ie why
you can't just plug in the wdt_i6300esb, which I think
is a PCI watchdog device). We try not to add devices to
virt unless we have to, because they increase the security
attack surface.

thanks
-- PMM