[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 03/15] hw/core/clock: add the clock_new helper function
From: |
Luc Michel |
Subject: |
[PATCH v3 03/15] hw/core/clock: add the clock_new helper function |
Date: |
Sat, 10 Oct 2020 15:57:47 +0200 |
This function creates a clock and parents it to another object with a given
name. It calls clock_setup_canonical_path before returning the new
clock.
This function is useful to create clocks in devices when one doesn't
want to expose it at the qdev level (as an input or an output).
Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Luc Michel <luc@lmichel.fr>
---
include/hw/clock.h | 13 +++++++++++++
hw/core/clock.c | 15 +++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/include/hw/clock.h b/include/hw/clock.h
index c93e6113cd..81bcf3e505 100644
--- a/include/hw/clock.h
+++ b/include/hw/clock.h
@@ -93,10 +93,23 @@ extern const VMStateDescription vmstate_clock;
*
* compute the canonical path of the clock (used by log messages)
*/
void clock_setup_canonical_path(Clock *clk);
+/**
+ * clock_new:
+ * @parent: the clock parent
+ * @name: the clock object name
+ *
+ * Helper function to create a new clock and parent it to @parent. There is no
+ * need to call clock_setup_canonical_path on the returned clock as it is done
+ * by this function.
+ *
+ * @return the newly created clock
+ */
+Clock *clock_new(Object *parent, const char *name);
+
/**
* clock_set_callback:
* @clk: the clock to register the callback into
* @cb: the callback function
* @opaque: the argument to the callback
diff --git a/hw/core/clock.c b/hw/core/clock.c
index 81184734e0..8c6af223e7 100644
--- a/hw/core/clock.c
+++ b/hw/core/clock.c
@@ -21,10 +21,25 @@ void clock_setup_canonical_path(Clock *clk)
{
g_free(clk->canonical_path);
clk->canonical_path = object_get_canonical_path(OBJECT(clk));
}
+Clock *clock_new(Object *parent, const char *name)
+{
+ Object *obj;
+ Clock *clk;
+
+ obj = object_new(TYPE_CLOCK);
+ object_property_add_child(parent, name, obj);
+ object_unref(obj);
+
+ clk = CLOCK(obj);
+ clock_setup_canonical_path(clk);
+
+ return clk;
+}
+
void clock_set_callback(Clock *clk, ClockCallback *cb, void *opaque)
{
clk->callback = cb;
clk->callback_opaque = opaque;
}
--
2.28.0
- [PATCH v3 00/15] raspi: add the bcm2835 cprman clock manager, Luc Michel, 2020/10/10
- [PATCH v3 04/15] hw/arm/raspi: fix CPRMAN base address, Luc Michel, 2020/10/10
- [PATCH v3 02/15] hw/core/clock: trace clock values in Hz instead of ns, Luc Michel, 2020/10/10
- [PATCH v3 03/15] hw/core/clock: add the clock_new helper function,
Luc Michel <=
- [PATCH v3 06/15] hw/misc/bcm2835_cprman: add a PLL skeleton implementation, Luc Michel, 2020/10/10
- [PATCH v3 01/15] hw/core/clock: provide the VMSTATE_ARRAY_CLOCK macro, Luc Michel, 2020/10/10
- [PATCH v3 05/15] hw/arm/raspi: add a skeleton implementation of the CPRMAN, Luc Michel, 2020/10/10
- [PATCH v3 07/15] hw/misc/bcm2835_cprman: implement PLLs behaviour, Luc Michel, 2020/10/10
- [PATCH v3 08/15] hw/misc/bcm2835_cprman: add a PLL channel skeleton implementation, Luc Michel, 2020/10/10
- [PATCH v3 10/15] hw/misc/bcm2835_cprman: add a clock mux skeleton implementation, Luc Michel, 2020/10/10