Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

[David Edmondson]

On Wednesday, 2020-12-16 at 07:43:53 +01, Andrew Jones wrote:

> On Tue, Dec 15, 2020 at 06:20:48PM +0000, David Edmondson wrote:
>> On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote:
>> 
>> >  static void fdt_add_cpu_nodes(const VirtMachineState *vms)
>> >  {
>> > -    int cpu;
>> > -    int addr_cells = 1;
>> >      const MachineState *ms = MACHINE(vms);
>> > +    int smp_cpus = ms->smp.cpus, cpu;
>> 
>> Is it house-style to have initialised and un-initialised local variables
>> declared on the same line?
>>
>
> checkpatch.pl doesn't complain and a grep of qemu shows hundreds of other
> examples. That said, I only see one other example in hw/arm/virt.c, so if
> we'd rather avoid it, I'll repost.

Not at all, I was just curious.

dme.
-- 
Driving at 90 down those country lanes, singing to "Tiny Dancer".