[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/24] target/arm: Add ALIGN_MEM to TBFLAG_ANY
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 02/24] target/arm: Add ALIGN_MEM to TBFLAG_ANY |
|
Date: |
Thu, 7 Jan 2021 09:58:17 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 1/7/21 5:42 AM, Peter Maydell wrote:
>> +/* Memory operations require alignment: SCTLR_ELx.A or CCR.UNALIGN_TRP */
>> +FIELD(TBFLAG_ANY, ALIGN_MEM, 19, 1)
>
> This is trying to use the same bit as TBFLAG_A64 MTE0_ACTIVE...
> We might have to finally start in on using bits in cs_base.
Oops. Didn't notice this as I extended from a32 to a64. And then of course
didn't enable mte while testing alignment...
I'll use cs_base in the next version, moving all of the target-specific bits
there, leaving only TBFLAG_ANY_* in tb->flags.
r~