Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

[Marian Posteuca]

Igor Mammedov <imammedo@redhat.com> writes:

> overall looks good.
> Please add a test case for it, see
> tests/qtest/bios-tables-test.c for description how to do it
> an/or at
>   "[PATCH v3 08/12] tests/acpi: allow updates for expected data files"
> and follow up patches on the list.
When you say add a test case, do you mean only updating the binary
files in tests/data/acpi/{microvm,pc,q35,virt} according to the steps
at the start of the file bios-tables-test.c? Or do you also mean an actual
test case to be added in bios-tables-test.c?

Also the step 6 described in bios-tables-test.c mentions that the diff of
the ACPI table must be added to the commit log, but my change touches
all the tables for all architectures so that would mean that I would
have to create a huge commit log. How should I approach this?