[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_con
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate |
|
Date: |
Thu, 25 Feb 2021 10:41:16 -0500 |
On Thu, Feb 25, 2021 at 10:14:29AM +0100, Eric Auger wrote:
> With -Werror=maybe-uninitialized configuration we get
> ../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’:
> ../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> 1888 | mask = ~mask;
> | ~~~~~^~~~~~~
>
> Add a g_assert_not_reached() to avoid the error.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v2 0/7] Some vIOMMU fixes, Eric Auger, 2021/02/25
- [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate, Eric Auger, 2021/02/25
- [PATCH v2 2/7] dma: Introduce dma_aligned_pow2_mask(), Eric Auger, 2021/02/25
- [PATCH v2 3/7] virtio-iommu: Handle non power of 2 range invalidations, Eric Auger, 2021/02/25
- [PATCH v2 4/7] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set, Eric Auger, 2021/02/25
- [PATCH v2 6/7] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling, Eric Auger, 2021/02/25
- [PATCH v2 5/7] hw/arm/smmuv3: Enforce invalidation on a power of two range, Eric Auger, 2021/02/25
- [PATCH v2 7/7] hw/arm/smmuv3: Uniformize sid traces, Eric Auger, 2021/02/25