qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/24] hw/arm/mps2-tz: Make the OSCCLK settings be configu


From: Richard Henderson
Subject: Re: [PATCH v2 04/24] hw/arm/mps2-tz: Make the OSCCLK settings be configurable per-board
Date: Sun, 28 Feb 2021 18:58:00 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 2/15/21 3:51 AM, Peter Maydell wrote:
+    uint32_t len_oscclk;
...
+    int i;
...
+    for (i = 0; i < mmc->len_oscclk; i++) {

Shouldn't mix types.  I'm surprised you didn't see a warning.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]