qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 31/44] hw/arm/armsse: Indirect irq_is_common[] through ARMSSE


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 31/44] hw/arm/armsse: Indirect irq_is_common[] through ARMSSEInfo
Date: Thu, 4 Mar 2021 21:19:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/19/21 3:46 PM, Peter Maydell wrote:
> The SSE-300 has a slightly different set of shared-per-CPU interrupts,
> allow the irq_is_common[] array to be different per SSE variant.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/arm/armsse.c | 39 +++++++++++++++++++++------------------
>  1 file changed, 21 insertions(+), 18 deletions(-)
> 
> diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c
> index f43f0524e28..b316fe69571 100644
> --- a/hw/arm/armsse.c
> +++ b/hw/arm/armsse.c
> @@ -68,6 +68,7 @@ struct ARMSSEInfo {
>      bool has_cpuid;
>      Property *props;
>      const ARMSSEDeviceInfo *devinfo;
> +    const bool *irq_is_common;

Maybe *const?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]