Re: [PATCH v3 2/5] tests/acceptance/boot_linux_console: remove Armbian 19.11.3 bionic test for orangepi-pc machine

[Willian Rampazzo]

On Mon, Mar 22, 2021 at 3:47 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 3/22/21 6:18 PM, Willian Rampazzo wrote:
> > Hi Philippe,
> >
> > On Mon, Mar 22, 2021 at 1:54 PM Philippe Mathieu-Daudé <f4bug@amsat.org> 
> > wrote:
> >>
> >> Hi Willian,
> >>
> >> On 3/8/21 9:44 PM, Willian Rampazzo wrote:
> >>> On Mon, Mar 8, 2021 at 5:41 PM Willian Rampazzo <wrampazz@redhat.com> 
> >>> wrote:
> >>>>
> >>>> On Mon, Mar 8, 2021 at 5:32 PM Niek Linnenbank 
> >>>> <nieklinnenbank@gmail.com> wrote:
> >>>>>
> >>>>> Hi Philippe, Willian,
> >>>>>
> >>>>> On Mon, Mar 8, 2021 at 8:52 AM Philippe Mathieu-Daudé 
> >>>>> <philmd@redhat.com> wrote:
> >>>>>>
> >>>>>> On 3/5/21 4:16 PM, Willian Rampazzo wrote:
> >>>>>>> On Thu, Mar 4, 2021 at 5:44 PM Niek Linnenbank 
> >>>>>>> <nieklinnenbank@gmail.com> wrote:
> >>>>>>>>
> >>>>>>>> The image for Armbian 19.11.3 bionic has been removed from the 
> >>>>>>>> armbian server.
> >>>>>>>> Without the image as input the test arm_orangepi_bionic_19_11 cannot 
> >>>>>>>> run.
> >>>>>>>>
> >>>>>>>> This commit removes the test completely and merges the code of the 
> >>>>>>>> generic function
> >>>>>>>> do_test_arm_orangepi_uboot_armbian back with the 20.08 test.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> >>>>>>>> ---
> >>>>>>>>  tests/acceptance/boot_linux_console.py | 72 
> >>>>>>>> ++++++++------------------
> >>>>>>>>  1 file changed, 23 insertions(+), 49 deletions(-)
> >>>>>>>>
> >>>>>>>> diff --git a/tests/acceptance/boot_linux_console.py 
> >>>>>>>> b/tests/acceptance/boot_linux_console.py
> >>>>>>>> index eb01286799..9fadea9958 100644
> >>>>>>>> --- a/tests/acceptance/boot_linux_console.py
> >>>>>>>> +++ b/tests/acceptance/boot_linux_console.py
> >>>>>>>> @@ -802,7 +802,29 @@ def test_arm_orangepi_sd(self):
> >>>>>>>>          # Wait for VM to shut down gracefully
> >>>>>>>>          self.vm.wait()
> >>>>>>>>
> >>>>>>>> -    def do_test_arm_orangepi_uboot_armbian(self, image_path):
> >>>>>>>> +    @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> >>>>>>>> +                'Test artifacts fetched from unreliable 
> >>>>>>>> apt.armbian.com')
> >>>>>>>> +    @skipUnless(os.getenv('AVOCADO_ALLOW_LARGE_STORAGE'), 'storage 
> >>>>>>>> limited')
> >>>>>>>> +    def test_arm_orangepi_bionic_20_08(self):
> >>>>>>>> +        """
> >>>>>>>> +        :avocado: tags=arch:arm
> >>>>>>>> +        :avocado: tags=machine:orangepi-pc
> >>>>>>>> +        :avocado: tags=device:sd
> >>>>>>>> +        """
> >>>>>>>> +
> >>>>>>>> +        # This test download a 275 MiB compressed image and expand 
> >>>>>>>> it
> >>>>>>>> +        # to 1036 MiB, but the underlying filesystem is 1552 MiB...
> >>>>>>>> +        # As we expand it to 2 GiB we are safe.
> >>>>>>>> +
> >>>>>>>> +        image_url = ('https://dl.armbian.com/orangepipc/archive/'
> >>>>>>>> +                     
> >>>>>>>> 'Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz')
> >>>>>>>
> >>>>>>> The Armbian 20 is not available on this link anymore. I can browse 
> >>>>>>> just 21.
> >>>>>>
> >>>>>> Cat-and-mouse game *sigh*.
> >>
> >> 2021-03-22 17:18:10,701 download         L0067 INFO | Fetching
> >> https://archive.armbian.com/orangepipc/archive/Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz
> >> -> /home/phil/avocado/da
> >> ta/cache/by_location/f2eb27a12b81ce15e93f340fabbced2136af1caa/Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz.nfwdzivg
> >> 2021-03-22 17:18:11,263 asset            L0136 INFO | Temporary asset
> >> file unavailable due to failed download attempt.
> >> 2021-03-22 17:18:11,263 asset            L0368 ERROR| URLError: <urlopen
> >> error [Errno 113] No route to host>
> >>
> >> It might be a temporary problem, but looking long term the
> >> current setup doesn't scale IMHO.
> >>
> >
> > Have you changed something in the test? The test is supposed to skip
> > when the asset is not available in the cache. What was the result of
> > this test execution? Skip, fail, or error? If it was not Skip, we need
> > to investigate what happened.
>
> No change, on commit b1847509268.
>
> The result was all good but 1 "Cancelled" so I looked at the job.log.
>
> All good IMO.
>

Okay, good! Unfortunately, I don't think there is much more we can do
on the qemu side or on Avocado side to handle network glitches.