[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/24] hw/block: m25p80: Add support for mt25qu02g
From: |
Francisco Iglesias |
Subject: |
Re: [PATCH 21/24] hw/block: m25p80: Add support for mt25qu02g |
Date: |
Thu, 8 Apr 2021 09:00:02 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hello Cedric!
On Wed, Apr 07, 2021 at 07:16:34PM +0200, Cédric Le Goater wrote:
> The Micron mt25qu02g is a 3V 2Gb serial NOR flash memory supporting
> dual I/O and quad I/O, 4KB, 32KB, 64KB sector erase. It also supports
> 4B opcodes.
>
> Cc: Alistair Francis <alistair.francis@wdc.com>
> Cc: Francisco Iglesias <francisco.iglesias@xilinx.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/block/m25p80.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 183d3f44c259..2afb939ae28e 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -259,6 +259,7 @@ static const FlashPartInfo known_devices[] = {
> { INFO_STACKED("n25q00a", 0x20bb21, 0x1000, 64 << 10, 2048, ER_4K, 4)
> },
> { INFO_STACKED("mt25ql01g", 0x20ba21, 0x1040, 64 << 10, 2048, ER_4K, 2)
> },
> { INFO_STACKED("mt25qu01g", 0x20bb21, 0x1040, 64 << 10, 2048, ER_4K, 2)
> },
> + { INFO_STACKED("mt25qu02g", 0x20ba22, 0x1040, 64 << 10, 4096, ER_4K, 2)
> },
Is it possible it should be as below instead?
{ INFO_STACKED("mt25qu02g", 0x20bb22, 0x1040, 64 << 10, 4096, ER_4K | ER_32K,
2) },
's/0x20ba22/0x20bb22/' (or 's/mt25qu02g/mt25ql02g/') since 'u' looks to stand
for 1.7-2.0 V and 'bb' for 1.8 V (see page 2 and 32 in [1]).
s/ER_4K/ER_4K | ER_32K/ since ERASE_32K is supported (see page 36).
If you find above changes ok and go with them please add:
Reviewed-by: Francisco Iglesias <francisco.iglesias@xilinx.com>
Best regards,
Francisco Iglesias
[1] Micron Serial NOR Flash Memory 1.8V, Multiple I/O, 64KB Sector Erase
MT25QU02GCBB
https://4donline.ihs.com/images/VipMasterIC/IC/MICT/MICT-S-A0008500026/MICT-S-A0008511423-1.pdf?hkey=52A5661711E402568146F3353EA87419
>
> /* Spansion -- single (large) sector size only, at least
> * for the chips listed here (without boot sectors).
> --
> 2.26.3
>
- Re: [PATCH 17/24] aspeed: Remove swift-bmc machine, (continued)
Re: [PATCH 17/24] aspeed: Remove swift-bmc machine, Adriana Kobylak, 2021/04/07
[PATCH 11/24] tests/acceptance: Test ast2400 and ast2500 machines, Cédric Le Goater, 2021/04/07
[PATCH 18/24] aspeed: Add support for the rainier-bmc board, Cédric Le Goater, 2021/04/07
[PATCH 23/24] arm/aspeed: Add DPS310 to rainier, Cédric Le Goater, 2021/04/07
[PATCH 21/24] hw/block: m25p80: Add support for mt25qu02g, Cédric Le Goater, 2021/04/07
[PATCH 15/24] aspeed/smc: Add extra controls to request DMA, Cédric Le Goater, 2021/04/07
[PATCH 16/24] tests/qtest: Rename m25p80 test in aspeed_smc test, Cédric Le Goater, 2021/04/07
[PATCH 19/24] hw/misc: Add an iBT device model, Cédric Le Goater, 2021/04/07
[PATCH 24/24] arm/aspeed: Add DPS310 to witherspoon, Cédric Le Goater, 2021/04/07