[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/sd/omap_mmc: Use device_cold_reset() instead of device_le
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] hw/sd/omap_mmc: Use device_cold_reset() instead of device_legacy_reset() |
Date: |
Sat, 01 May 2021 07:55:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Peter Maydell <peter.maydell@linaro.org> writes:
> The omap_mmc_reset() function resets its SD card via
> device_legacy_reset(). We know that the SD card does not have a qbus
> of its own, so the new device_cold_reset() function (which resets
> both the device and its child buses) is equivalent here to
> device_legacy_reset() and we can just switch to the new API.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> cc'ing Markus who was interested in conversions away from
> the legacy API. As warned, the conversion patch itself is
> not very interesting as the difficulty is all in confirming
> that the device being reset has no qbuses...
The commit messsage makes this helpful. Thanks!
I wonder whether we should add a hint to device_legacy_reset()'s
comment.
- Re: [PATCH] hw/sd/omap_mmc: Use device_cold_reset() instead of device_legacy_reset(),
Markus Armbruster <=