Re: [PATCH v6 75/82] target/arm: Split out do_neon_ddda_fpst

[Peter Maydell]

On Fri, 30 Apr 2021 at 22:35, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Split out a helper that can handle the 4-register
> format for helpers shared with SVE.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/translate-neon.c | 98 ++++++++++++++++---------------------
>  1 file changed, 43 insertions(+), 55 deletions(-)
>
> diff --git a/target/arm/translate-neon.c b/target/arm/translate-neon.c
> index 45fa5166f3..41a7b2208e 100644
> --- a/target/arm/translate-neon.c
> +++ b/target/arm/translate-neon.c
> @@ -151,24 +151,21 @@ static void neon_store_element64(int reg, int ele, 
> MemOp size, TCGv_i64 var)
>      }
>  }
>
> -static bool trans_VCMLA(DisasContext *s, arg_VCMLA *a)
> +static bool do_neon_ddda_fpst(DisasContext *s, int q, int vd, int vn, int vm,
> +                              int data, ARMFPStatusFlavour fp_flavor,

Can we keep the UK "flavour" spelling for the argument to match the
type name, please? :-)

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM