|
From: | Richard Henderson |
Subject: | Re: [PATCH v6 77/82] target/arm: Fix decode for VDOT (indexed) |
Date: | Sat, 15 May 2021 12:20:43 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/13/21 2:25 PM, Peter Maydell wrote:
+static bool do_neon_ddda(DisasContext *s, int q, int vd, int vn, int vm, + int data, gen_helper_gvec_4 *fn_gvec)This patch seems to be doing more than its commit message suggests. If we want to share code between trans_VDOT and trans_VDOT_scalar can we do that refactoring in its own patch, please ?
It appears as if a rebasing error squashed two patches together (git commit --amend vs git rebase --continue after conflicts). I nearly made the identical mistake while splitting this apart again just now. :-P r~
[Prev in Thread] | Current Thread | [Next in Thread] |