[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64
From: |
Alex Bennée |
Subject: |
Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64 |
Date: |
Tue, 08 Jun 2021 15:27:00 +0100 |
User-agent: |
mu4e 1.5.13; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> On 6/4/21 8:53 AM, Alex Bennée wrote:
>> The assumption that the qemu-system-aarch64 image can run all 32 bit
>> machines is about to be broken...
>
> Um, what?
Really what we want is to probe the -M (machines) that a binary
supports rather than just barfing the test because we've built a QEMU
that doesn't support all the random 32 bit machines.
> r~
>
>
>
> and besides it's not likely this is
>> improving out coverage by much. Test the "virt" machine for both arm
>> and aarch64 as it can be used by either architecture.
I think this point still stands though, I don't think we get much from
running the cdrom test with realview et all on qemu-system-aarch64.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> tests/qtest/cdrom-test.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
>> index 5af944a5fb..1e74354624 100644
>> --- a/tests/qtest/cdrom-test.c
>> +++ b/tests/qtest/cdrom-test.c
>> @@ -220,13 +220,16 @@ int main(int argc, char **argv)
>> "magnum", "malta", "pica61", NULL
>> };
>> add_cdrom_param_tests(mips64machines);
>> - } else if (g_str_equal(arch, "arm") || g_str_equal(arch, "aarch64")) {
>> + } else if (g_str_equal(arch, "arm")) {
>> const char *armmachines[] = {
>> "realview-eb", "realview-eb-mpcore", "realview-pb-a8",
>> "realview-pbx-a9", "versatileab", "versatilepb",
>> "vexpress-a15",
>> "vexpress-a9", "virt", NULL
>> };
>> add_cdrom_param_tests(armmachines);
>> + } else if (g_str_equal(arch, "aarch64")) {
>> + const char *aarch64machines[] = { "virt", NULL };
>> + add_cdrom_param_tests(aarch64machines);
>> } else {
>> const char *nonemachine[] = { "none", NULL };
>> add_cdrom_param_tests(nonemachine);
>>
--
Alex Bennée
- Re: [PATCH v16 10/99] qtest/bios-tables-test: Rename TCG specific tests, (continued)
- [PATCH v16 87/99] target/arm: move arm_cpu_finalize_features into cpu64, Alex Bennée, 2021/06/04
- [PATCH v16 77/99] target/arm: arch_dump: restrict ELFCLASS64 to AArch64, Alex Bennée, 2021/06/04
- [PATCH v16 36/99] target/arm: move arm_mmu_idx* to cpu-mmu, Alex Bennée, 2021/06/04
- [PATCH v16 86/99] target/arm: cpu-pauth: change arm_cpu_pauth_finalize name and sig, Alex Bennée, 2021/06/04
- [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Alex Bennée, 2021/06/04
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Richard Henderson, 2021/06/05
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64,
Alex Bennée <=
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Thomas Huth, 2021/06/08
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Richard Henderson, 2021/06/08
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Thomas Huth, 2021/06/08
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Alex Bennée, 2021/06/08
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, Thomas Huth, 2021/06/08
- Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, John Snow, 2021/06/08
Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64, John Snow, 2021/06/08