qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.2 51/53] target/arm: Implement MVE VCVT between single


From: Richard Henderson
Subject: Re: [PATCH for-6.2 51/53] target/arm: Implement MVE VCVT between single and half precision
Date: Fri, 30 Jul 2021 10:33:51 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/29/21 1:15 AM, Peter Maydell wrote:
+/*
+ * VCVT between halfprec and singleprec. As usual for halfprec
+ * conversions, FZ16 is ignored and AHP is observed.
+ */
+#define DO_VCVT_SH(OP, TOP)                                             \
+    void HELPER(glue(mve_, OP))(CPUARMState *env, void *vd, void *vm)   \

These might be easier to read as a local function with an extra "top" argument, rather than as a macro, since you're not passing in anything complicated.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]