[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/3] pc: Support configuration of SMBIOS entry point type
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v3 0/3] pc: Support configuration of SMBIOS entry point type |
Date: |
Mon, 1 Nov 2021 18:32:40 -0400 |
On Tue, Oct 26, 2021 at 11:10:57AM -0400, Eduardo Habkost wrote:
> This includes code previously submitted[1] by Daniel P. Berrangé
> to add a "smbios-ep" machine property on PC.
>
> SMBIOS 3.0 is necessary to support more than ~720 VCPUs, as a
> large number of VCPUs can easily hit the table size limit of
> SMBIOS 2.1 entry points.
We need acks from QAPI supporters on this.
> Changes from v2:
> * Renamed option to "smbios-entry-point-type" for clarity
> * Renamed option values to "32" and "64", for two reasons:
> * The option is not about reporting an exact SMBIOS
> version, but just the entry point format.
> FWIW, the SMBIOS specification uses the phrases "32-bit entry
> point" and "64-bit entry point" more often than "2.1 entry
> point" and "3.0 entry point".
> * QAPI doesn't allow us to use enum member names with dots
> or underscores
>
> [1]
> https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berrange@redhat.com
>
> https://lore.kernel.org/qemu-devel/20200908165438.1008942-6-berrange@redhat.com
>
> Eduardo Habkost (3):
> smbios: Rename SMBIOS_ENTRY_POINT_* enums
> hw/smbios: Use qapi for SmbiosEntryPointType
> hw/i386: expose a "smbios-entry-point-type" PC machine property
>
> include/hw/firmware/smbios.h | 10 ++--------
> include/hw/i386/pc.h | 4 ++++
> hw/arm/virt.c | 2 +-
> hw/i386/pc.c | 26 ++++++++++++++++++++++++++
> hw/i386/pc_piix.c | 2 +-
> hw/i386/pc_q35.c | 2 +-
> hw/smbios/smbios.c | 8 ++++----
> qapi/machine.json | 12 ++++++++++++
> 8 files changed, 51 insertions(+), 15 deletions(-)
>
> --
> 2.32.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 0/3] pc: Support configuration of SMBIOS entry point type,
Michael S. Tsirkin <=