|
From: | Philippe Mathieu-Daudé |
Subject: | Re: Analysis of slow distro boots in check-avocado (BootLinuxAarch64.test_virt_tcg*) |
Date: | Wed, 23 Feb 2022 14:34:23 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 |
On 23/2/22 12:07, Daniel P. Berrangé wrote:
On Tue, Feb 22, 2022 at 06:33:41PM +0100, Philippe Mathieu-Daudé wrote:+Igor/MST for UEFI tests. On 22/2/22 17:38, Daniel P. Berrangé wrote:On Tue, Feb 22, 2022 at 04:17:23PM +0000, Alex Bennée wrote:Alex Bennée <alex.bennee@linaro.org> writes:Hi, TL;DR: - pc-bios/edk2-aarch64-code.fd should be rebuilt without debugLaszlo, Would it be possible to do a less debug enabled version of EDK2 on the next update to pc-bios/edk2-*?NB, Laszlo is no longer maintaining EDK2 in QEMU, it was handed over to Philippe. I'm CC'ing Gerd too since he's a reviewer and an EDK2 contributor taking over from Lazslo in EDK2 communityWe need the DEBUG profile to ensure the bios-tables-tests work.Can you elaborate on what bios-tables-tests needs this for, and what coverage we would loose by disabling DEBUG.
Maybe it was only required when the tests were developed... I'll defer that question to Igor.
It may well be a better tradeoff to sacrifice part of bios-tables-tests in favour of shipping more broadly usable images without DEBUG.
Why not, if users are aware/happy to use a unsafe image with various unfixed CVEs. Removing the debug profile is as simple as this one-line patch: -- >8 -- diff --git a/roms/edk2-build.sh b/roms/edk2-build.sh index d5391c7637..ea79dc27a2 100755 --- a/roms/edk2-build.sh +++ b/roms/edk2-build.sh @@ -50,6 +50,6 @@ qemu_edk2_set_cross_env "$emulation_target" build \ --cmd-len=65536 \ -n "$edk2_thread_count" \ - --buildtarget=DEBUG \ + --buildtarget=RELEASE \ --tagname="$edk2_toolchain" \ "${args[@]}" ---
[Prev in Thread] | Current Thread | [Next in Thread] |