qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.1 05/18] hw/arm/exynos4210: Coalesce board_irqs and irq


From: Richard Henderson
Subject: Re: [PATCH for-7.1 05/18] hw/arm/exynos4210: Coalesce board_irqs and irq_table
Date: Wed, 6 Apr 2022 08:45:42 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 4/4/22 10:46, Peter Maydell wrote:
The exynos4210 code currently has two very similar arrays of IRQs:

  * board_irqs is a field of the Exynos4210Irq struct which is filled
    in by exynos4210_init_board_irqs() with the appropriate qemu_irqs
    for each IRQ the board/SoC can assert
  * irq_table is a set of qemu_irqs pointed to from the
    Exynos4210State struct.  It's allocated in exynos4210_init_irq,
    and the only behaviour these irqs have is that they pass on the
    level to the equivalent board_irqs[] irq

The extra indirection through irq_table is unnecessary, so coalesce
these into a single irq_table[] array as a direct field in
Exynos4210State which exynos4210_init_board_irqs() fills in.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  include/hw/arm/exynos4210.h |  8 ++------
  hw/arm/exynos4210.c         |  6 +-----
  hw/intc/exynos4210_gic.c    | 32 ++++++++------------------------
  3 files changed, 11 insertions(+), 35 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]