Re: [PATCH 13/41] hw/intc/arm_gicv3_its: Split out process_its_cmd() physical interrupt code

[Richard Henderson]

On 4/8/22 07:15, Peter Maydell wrote:
> Split the part of process_its_cmd() which is specific to physical
> interrupts into its own function.  This is the part which starts by
> taking the ICID and looking it up in the collection table.  The
> handling of virtual interrupts is significantly different (involving
> a lookup in the vPE table) so structuring the code with one
> sub-function for the physical interrupt case and one for the virtual
> interrupt case will be clearer than putting both cases in one large
> function.
>
> The code for handling the "remove mapping from ITE" for the DISCARD
> command remains in process_its_cmd() because it is common to both
> virtual and physical interrupts.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   hw/intc/arm_gicv3_its.c | 51 ++++++++++++++++++++++++++---------------
>   1 file changed, 33 insertions(+), 18 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~