Re: [PATCH v5 2/4] hw/arm/virt: Consider SMP configuration in CPU topology

[Gavin Shan]

Hi Jonathan,

On 4/14/22 5:33 PM, Jonathan Cameron wrote:
> On Thu, 14 Apr 2022 15:35:41 +0800
> Gavin Shan <gshan@redhat.com> wrote:
> > On 4/14/22 10:49 AM, wangyanan (Y) wrote:
> > > On 2022/4/14 10:37, Gavin Shan wrote:
> > > > On 4/14/22 10:27 AM, wangyanan (Y) wrote:
> > > > > On 2022/4/14 8:08, Gavin Shan wrote:
> > > > > > On 4/13/22 8:39 PM, wangyanan (Y) wrote:
> > > > > > > On 2022/4/3 22:59, Gavin Shan wrote:

[...]

> > > > > Oh, after further testing this patch breaks numa-test for aarch64,
> > > > > which should be checked and fixed. I guess it's because we have
> > > > > more IDs supported for ARM. We have to fully running the QEMU
> > > > > tests before sending some patches to ensure that they are not
> > > > > breaking anything. :)
> > > > >   
> > > >
> > > > Thanks for catching the failure and reporting back. I'm not
> > > > too much familar with QEMU's test workframe. Could you please
> > > > share the detailed commands to reproduce the failure? I will
> > > > fix in v6, which will be done in a separate patch :)
> > > >   
> > > There is a reference link: https://wiki.qemu.org/Testing
> > > To catch the failure of this patch: "make check" will be enough.
> > >    
>
> Speaking from experience, best bet is also upload to a gitlab repo
> and let the CI hit things. It will catch this plus any weirdness
> elsewhere without you having to figure out too much unless you see
> a failure.
>
> The CI is pretty good though more tests always needed!

Thanks a lot for the hint. I usually use github to host my code.
I will setup gitlab repositories so that the verification and
tests can be automated. Not sure if there is any document on
how to trigger the automatic verification and testing from
gitlab?

[...]

Thanks,
Gavin