Re: [PATCH v4 2/3] aspeed/hace: Support AST2600 HACE

[Cédric Le Goater]

Hello Steven,

> > > +static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode,
> > > +                              bool acc_mode)
> > >    {
> > >        struct iovec iov[ASPEED_HACE_MAX_SG];
> > >        g_autofree uint8_t *digest_buf;
> > >        size_t digest_len = 0;
> > > +    int niov = 0;
> > >        int i;
> > > +    static struct iovec iov_cache[ASPEED_HACE_MAX_SG];
> > > +    static int count;
> > > +    static uint32_t total_len;
> >
> > Why static ? Shouldn't these be AspeedHACEState attributes instead ?
>
> will add these static variables in AspeedHACEState.

When you do, please update the reset handler and the vmstate.

Thanks,

C.