[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] Define NPCM7XX PWRON bit fields
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 0/2] Define NPCM7XX PWRON bit fields |
|
Date: |
Thu, 21 Apr 2022 11:30:15 +0100 |
On Mon, 11 Apr 2022 at 17:58, Hao Wu <wuhaotsh@google.com> wrote:
>
> Currently, the PWRON STRAP values in NPCM7XX boards are magic
> numbers. Similar to the aspeed ones in hw/arm/aspeed.c, we
> define bit fields constants for them and use these fields instead
> of the magic numbers in the current implementation. The code
> should behave exactly the same as the existing one.
>
> -- Changes since v1
> * Fix errors and apply suggestions Peter made on v1.
Applied to target-arm.next, thanks.
-- PMM