Re: [PATCH for-7.1 03/11] hw/misc: Support NPCM8XX GCR module

[Peter Maydell]

On Tue, 5 Apr 2022 at 23:38, Hao Wu <wuhaotsh@google.com> wrote:
>
> NPCM8XX has a different set of global control registers than 7XX.
> This patch supports that.
>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> Reviwed-by: Titus Rwantare <titusr@google.com>
> ---


> diff --git a/hw/misc/npcm7xx_gcr.c b/hw/misc/npcm7xx_gcr.c
> deleted file mode 100644
> index eace9e1967..0000000000
> --- a/hw/misc/npcm7xx_gcr.c
> +++ /dev/null
> @@ -1,269 +0,0 @@


> diff --git a/hw/misc/npcm_gcr.c b/hw/misc/npcm_gcr.c
> new file mode 100644
> index 0000000000..2349949599
> --- /dev/null
> +++ b/hw/misc/npcm_gcr.c
> @@ -0,0 +1,413 @@

I'm not reviewing a patch that implements this as "delete 250
lines of the old file and add 400 lines of new file" when
they're clearly very similar. Please split this up in a way
that makes the changes visible and reviewable (probably this
is one patch doing "rename file" and then one or more patches
making the code less 7xx specific and then a patch adding
the 8xx type).

thanks
-- PMM