[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] target/arm: Remove useless TARGET_BIG_ENDIAN check in ar

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 1/2] target/arm: Remove useless TARGET_BIG_ENDIAN check in armv7m_load_kernel()
Date: Tue, 30 Aug 2022 14:24:48 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 23/8/22 18:04, Peter Maydell wrote:
Arm system emulation targets always have TARGET_BIG_ENDIAN clear, so
there is no need to have handling in armv7m_load_kernel() for the
case when it is defined.  Remove the unnecessary code.

Side notes:
  * our M-profile implementation is always little-endian (that is, it
    makes the IMPDEF choice that the read-only AIRCR.ENDIANNESS is 0)
  * if we did want to handle big-endian ELF files here we should do it
    the way that hw/arm/boot.c:arm_load_elf() does, by looking at the
    ELF header to see what endianness the file itself is

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  hw/arm/armv7m.c | 9 +--------
  1 file changed, 1 insertion(+), 8 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]