[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] pci: Assert that capabilities never overlap
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v2] pci: Assert that capabilities never overlap |
Date: |
Thu, 13 Oct 2022 10:45:28 -0400 |
On Thu, Oct 13, 2022 at 02:39:27PM +0900, Akihiko Odaki wrote:
> Yes, I'd like to hear your ideas on how it should be split up. The
> main challenge here is that it changes the signature of a function
> without changing its name.
Lots of ways to do it, e.g.:
1. add a new api with a new name
2. change code to use new name
3. drop old api
4. add new api with old name
5. change code to use old name
or we can stop after 3, it's not too hard to come up
with a slightly different name.
Since all you are doing here is dropping an argument,
other hacks may be possible such as making the function
use variadic arguments temporarily.
--
MST