[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/9] hw/arm/tosa: Convert TYPE_TOSA_MISC_GPIO from SysBus to QDev
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 4/9] hw/arm/tosa: Convert TYPE_TOSA_MISC_GPIO from SysBus to QDev |
Date: |
Mon, 9 Jan 2023 10:26:12 +0100 |
Drop the pointless TosaMiscGPIOState structure definition,
since it defaults to the size of the parent's type.
Nothing in TYPE_TOSA_MISC_GPIO access the SysBus API,
convert it to a plain QDev.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/tosa.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c
index d5a6763cf9..ec0db24e8f 100644
--- a/hw/arm/tosa.c
+++ b/hw/arm/tosa.c
@@ -78,10 +78,6 @@ static void tosa_microdrive_attach(PXA2xxState *cpu)
#define TYPE_TOSA_MISC_GPIO "tosa-misc-gpio"
OBJECT_DECLARE_SIMPLE_TYPE(TosaMiscGPIOState, TOSA_MISC_GPIO)
-struct TosaMiscGPIOState {
- SysBusDevice parent_obj;
-};
-
static void tosa_reset(void *opaque, int line, int level)
{
if (level) {
@@ -104,7 +100,7 @@ static void tosa_gpio_setup(PXA2xxState *cpu,
DeviceState *misc_gpio;
LEDState *led[4];
- misc_gpio = sysbus_create_simple(TYPE_TOSA_MISC_GPIO, -1, NULL);
+ misc_gpio = qdev_create_simple(TYPE_TOSA_MISC_GPIO, &error_fatal);
/* MMC/SD host */
pxa2xx_mmci_handlers(cpu->mmc,
@@ -307,8 +303,7 @@ static const TypeInfo tosa_ssp_info = {
static const TypeInfo tosa_misc_gpio_info = {
.name = TYPE_TOSA_MISC_GPIO,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_size = sizeof(TosaMiscGPIOState),
+ .parent = TYPE_DEVICE,
.instance_init = tosa_misc_gpio_init,
/*
* No class init required: device has no internal state so does not
--
2.38.1
- [PATCH 0/9] hw: Convert simple devices from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 1/9] hw/arm/musicpal: Remove unused dummy MemoryRegion, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 2/9] qdev: Add qdev_create_simple() helper, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 3/9] hw/i2c/bitbang_i2c: Convert TYPE_GPIO_I2C from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 5/9] hw/arm/palm: Convert TYPE_PALM_MISC_GPIO from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 4/9] hw/arm/tosa: Convert TYPE_TOSA_MISC_GPIO from SysBus to QDev,
Philippe Mathieu-Daudé <=
- [PATCH 6/9] hw/arm/musicpal: Convert TYPE_MUSICPAL_KEY from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 7/9] hw/arm/spitz: Convert TYPE_SPITZ_KEYBOARD from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 8/9] hw/arm/tosa: Convert TYPE_SPITZ_MISC_GPIO from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 9/9] hw/i386/kvm: Convert TYPE_KVM_CLOCK from SysBus to QDev, Philippe Mathieu-Daudé, 2023/01/09
- Re: [PATCH 0/9] hw: Convert simple devices from SysBus to QDev, Peter Maydell, 2023/01/09