[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/13] hw/arm/gumstix: Use the IEC binary prefix definitions
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 06/13] hw/arm/gumstix: Use the IEC binary prefix definitions |
Date: |
Mon, 9 Jan 2023 12:53:09 +0100 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
IEC binary prefixes ease code review: the unit is explicit.
Add definitions for RAM / Flash / Flash blocksize.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200223231044.8003-3-philmd@redhat.com>
---
hw/arm/gumstix.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
index 89c15bee75..579d363577 100644
--- a/hw/arm/gumstix.c
+++ b/hw/arm/gumstix.c
@@ -35,6 +35,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/units.h"
#include "qemu/error-report.h"
#include "hw/arm/pxa.h"
#include "net/net.h"
@@ -45,17 +46,20 @@
#include "sysemu/qtest.h"
#include "cpu.h"
-static const int sector_len = 128 * 1024;
+#define CONNEX_FLASH_SIZE (16 * MiB)
+#define CONNEX_RAM_SIZE (64 * MiB)
+
+#define VERDEX_FLASH_SIZE (32 * MiB)
+#define VERDEX_RAM_SIZE (256 * MiB)
+
+#define FLASH_SECTOR_SIZE (128 * KiB)
static void connex_init(MachineState *machine)
{
PXA2xxState *cpu;
DriveInfo *dinfo;
- uint32_t connex_rom = 0x01000000;
- uint32_t connex_ram = 0x04000000;
-
- cpu = pxa255_init(connex_ram);
+ cpu = pxa255_init(CONNEX_RAM_SIZE);
dinfo = drive_get(IF_PFLASH, 0, 0);
if (!dinfo && !qtest_enabled()) {
@@ -65,9 +69,9 @@ static void connex_init(MachineState *machine)
}
/* Numonyx RC28F128J3F75 */
- if (!pflash_cfi01_register(0x00000000, "connext.rom", connex_rom,
+ if (!pflash_cfi01_register(0x00000000, "connext.rom", CONNEX_FLASH_SIZE,
dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
- sector_len, 2, 0, 0, 0, 0, 0)) {
+ FLASH_SECTOR_SIZE, 2, 0, 0, 0, 0, 0)) {
error_report("Error registering flash memory");
exit(1);
}
@@ -82,10 +86,7 @@ static void verdex_init(MachineState *machine)
PXA2xxState *cpu;
DriveInfo *dinfo;
- uint32_t verdex_rom = 0x02000000;
- uint32_t verdex_ram = 0x10000000;
-
- cpu = pxa270_init(verdex_ram, machine->cpu_type);
+ cpu = pxa270_init(VERDEX_RAM_SIZE, machine->cpu_type);
dinfo = drive_get(IF_PFLASH, 0, 0);
if (!dinfo && !qtest_enabled()) {
@@ -95,9 +96,9 @@ static void verdex_init(MachineState *machine)
}
/* Micron RC28F256P30TFA */
- if (!pflash_cfi01_register(0x00000000, "verdex.rom", verdex_rom,
+ if (!pflash_cfi01_register(0x00000000, "verdex.rom", VERDEX_FLASH_SIZE,
dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
- sector_len, 2, 0, 0, 0, 0, 0)) {
+ FLASH_SECTOR_SIZE, 2, 0, 0, 0, 0, 0)) {
error_report("Error registering flash memory");
exit(1);
}
--
2.38.1
- [PATCH 00/13] hw/arm: Cleanups before pflash refactor, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 01/13] hw/arm/pxa2xx: Simplify pxa255_init(), Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 02/13] hw/arm/pxa2xx: Simplify pxa270_init(), Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 03/13] hw/arm/collie: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 04/13] hw/arm/collie: Simplify flash creation using for() loop, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 06/13] hw/arm/gumstix: Use the IEC binary prefix definitions,
Philippe Mathieu-Daudé <=
- [PATCH 05/13] hw/arm/gumstix: Improve documentation, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 07/13] hw/arm/mainstone: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 08/13] hw/arm/musicpal: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 09/13] hw/arm/omap_sx1: Remove unused 'total_ram' definitions, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 10/13] hw/arm/omap_sx1: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 11/13] hw/arm/z2: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 12/13] hw/arm/vexpress: Remove dead code in vexpress_common_init(), Philippe Mathieu-Daudé, 2023/01/09
- [PATCH 13/13] hw/arm: Remove unreachable code calling pflash_cfi01_register(), Philippe Mathieu-Daudé, 2023/01/09
- Re: [PATCH 00/13] hw/arm: Cleanups before pflash refactor, Richard Henderson, 2023/01/09
- Re: [PATCH 00/13] hw/arm: Cleanups before pflash refactor, Peter Maydell, 2023/01/12